ci: add test duration tracking workflow#4290
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hsuan-lun-chiang
force-pushed
the
ci/test-duration-tracking
branch
from
caecacc to
b8d8e85
Compare
hsuan-lun-chiang
force-pushed
the
ci/test-duration-tracking
branch
from
b8d8e85 to
4473112
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ainer on self-hosted buildkit runner
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-${{ inputs.device_type }}-${{ inputs.worker_group }} |
There was a problem hiding this comment.
I think we should append ${{ github.run_id }} to the artifact name. This is to avoid mixing files from different runs.
For download, we should download files of the same run_id.
Can we also add the expiration time of these temporary files, such as:
retention-days: 1 # Automatically delete the artifact from the cloud after 24 hours
| comment-on-alert: true | ||
| fail-on-alert: true | ||
|
|
||
| - name: Upload Updated Baseline to GCS |
There was a problem hiding this comment.
Can we use gh-pages to store the benchmark data? github-action-benchmark can generate a index.html so we can see the interactive chart of the benchmark history.
2 participants
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
You can also provide a comma-separated list. If you don't want to close a bug but
simply to reference it, use BUGS, e.g.:
BUGS: b/123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.